-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/outreach section #77
Merged
chrisgarrity
merged 4 commits into
scratchfoundation:develop
from
chrisgarrity:feature/outreach-section
Aug 30, 2017
Merged
Feature/outreach section #77
chrisgarrity
merged 4 commits into
scratchfoundation:develop
from
chrisgarrity:feature/outreach-section
Aug 30, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new Outreach section for Family Days. * Outreach is added at the top level between Teach and Donate * Outreach section has three subsections: * About FD (default) - summary of Family Days * Host a FD - explains the Tufts study, and embeds the form to sign up * FD News - twitter feed of family days
Will need to create a widget on the ScratchJr twitter account that has the right query.
Update the placeholder timeline with the widget from the @ScratchJR twitter account set up by My Nguyen
Put print styles last. Add missing coloring sheets.
rschamp
approved these changes
Aug 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -70,10 +70,14 @@ module.exports = { | |||
}] | |||
}, | |||
{ | |||
test: /\.(png|jpg|gif|eot|svg|ttf|woff)$/, | |||
test: /\.(png|PNG|jpg|JPG|gif|GIF|eot|svg|ttf|woff)$/, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Testing
Test cases
|
Blocked pending discussion with Tufts on how to handle the above issues. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first part of #60 - adding the outreach section.
Content is from Tufts.
Full hosting info is an embedded, printable, HTML.