Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor convert_jsons_to_xcstrings.py for Improved File Handling and Error Management #62

Merged

Commits on Oct 6, 2024

  1. Configuration menu
    Copy the full SHA
    f354bb4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81da648 View commit details
    Browse the repository at this point in the history
  3. Optimize performance by pre-loading language JSON files

    - Refactored the code to load all language JSON files into memory once, reducing redundant file access.
    - Improved translation lookup efficiency by using a dictionary for language data, resulting in faster processing of keys.
    - Enhanced overall script performance, especially beneficial for larger datasets
    OmarAI2003 committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    d811de7 View commit details
    Browse the repository at this point in the history
  4. Remove automatic creation of the 'jsons' folder

    - Added a check to ensure the 'jsons' folder exists, exiting with an error message if it is missing.
    OmarAI2003 committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    d41c8eb View commit details
    Browse the repository at this point in the history
  5. Add error handling for missing base language file

    - Implemented a try-except block for loading 'en-US.json' to catch FileNotFoundError.
    - Added a user-friendly error message to indicate if the base language file is missing.
    OmarAI2003 committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    aee58c0 View commit details
    Browse the repository at this point in the history
  6. Rename variable for improved clarity

    - Changed variable name from 'file' to 'base_language_data' for better readability and to clearly indicate its purpose.
    OmarAI2003 committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    8925a4b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    9fcc0de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3e5fbf View commit details
    Browse the repository at this point in the history