Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accent characters menu option from i pads 477 #480

Conversation

fabulouiOS-monk
Copy link
Collaborator

Contributor checklist


Description

Implemented a check for iPad to remove Layout section from langSpecific settings.

Related issue

Copy link

github-actions bot commented Jul 29, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@fabulouiOS-monk
Copy link
Collaborator Author

@andrewtavis Please review PR, and check whether this is what you wanted.

@andrewtavis
Copy link
Member

Hey @fabulouiOS-monk 👋 Checking on this: Are we checking if there are no menu options and then removing it if so, or just removing it for iPads? The latter works well for now, but there will be options for this for iPads in the future, so the best thing would be to remove the option from iPads - this dropping the total options to 0 - and then write something that automatically removes it :)

@fabulouiOS-monk
Copy link
Collaborator Author

@andrewtavis currently we are removing the whole section if device in question is iPAD.

@fabulouiOS-monk
Copy link
Collaborator Author

and for the scenario where we need to add some options later on for iPAD in LAYOUT SECTION, we can just have a nested if check for it. Well.... let me push it out with a comment.

@fabulouiOS-monk
Copy link
Collaborator Author

fabulouiOS-monk commented Jul 29, 2024

@andrewtavis, Added condition to check which menu option it is based on sectionState if the sectionStates are toggleAccentCharacters & toggleCommaAndPeriod we will remove them, and if there are no sections we will remove the whole Layout.

@andrewtavis andrewtavis self-requested a review July 30, 2024 20:49
@andrewtavis
Copy link
Member

Just sent along a basic file reformat and also changed MARK: - to MARK: throughout the codebase as marks work without the dashes, so I don't see why we'd keep them 🤷‍♂️😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for pulling this through, @fabulouiOS-monk! Am going to do the data work now and send off v3.1 as soon as I can 🚀 So amazing to get the quick and effective help to get the new version out!

@andrewtavis andrewtavis merged commit b4c7fad into scribe-org:main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants