-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove accent characters menu option from i pads 477 #480
Remove accent characters menu option from i pads 477 #480
Conversation
…Remove-accent-characters-menu-option-from-iPads-477
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
@andrewtavis Please review PR, and check whether this is what you wanted. |
Hey @fabulouiOS-monk 👋 Checking on this: Are we checking if there are no menu options and then removing it if so, or just removing it for iPads? The latter works well for now, but there will be options for this for iPads in the future, so the best thing would be to remove the option from iPads - this dropping the total options to 0 - and then write something that automatically removes it :) |
@andrewtavis currently we are removing the whole section if device in question is iPAD. |
and for the scenario where we need to add some options later on for iPAD in LAYOUT SECTION, we can just have a nested if check for it. Well.... let me push it out with a comment. |
@andrewtavis, Added condition to check which menu option it is based on sectionState if the sectionStates are |
Just sent along a basic file reformat and also changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for pulling this through, @fabulouiOS-monk! Am going to do the data work now and send off v3.1 as soon as I can 🚀 So amazing to get the quick and effective help to get the new version out!
Contributor checklist
Description
Implemented a check for iPad to remove Layout section from langSpecific settings.
Related issue