Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed the HECommandVariables file #497

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanielGevaZA
Copy link
Contributor

@DanielGevaZA DanielGevaZA commented Aug 31, 2024

Contributor checklist


Description

Completed the HE file from the EN version. Added all the translations for the needed terms.

Related issue

Completed the HE file from the EN version. Added all the translations for the needed terms.
Copy link

github-actions bot commented Aug 31, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review August 31, 2024 20:05
@andrewtavis
Copy link
Member

Minor suggestions on your PR workflow for the next time, @DanielGevaZA :)

  • Putting #ISSUE_NUMBER at the start of your commit is good practice as it then links the commit to the given issue
  • It's be great if you filled out the commit message template in the future for your PR commit
    • I'll edit yours for this issue so you can see what we're looking for :)

@andrewtavis
Copy link
Member

andrewtavis commented Aug 31, 2024

Also I'm realizing that for this it'd make sense for us to be working on the Scribe-Data issue for this as well now, as we're trying to set up commands, but we haven't set out what the verb tenses are going to be for conjugate :)

Would you want to update the Wikidata query for Hebrew verbs at the following link (directions below):

You can find a Hebrew verb on Wikidata via a special search with L: at the start of it like the following:

From there, could you let me know what you'd say would be the ideal verb tenses to get from a verb like the following (as I understand it it's something like "to write", which should have good conjugation coverage):

And then we can reference the queries for other languages to get all their verbs and edit the Hebrew verbs query so that it returns all the conjugations we need 😊

Once we have that set, we'll then have a better understanding of what data we're trying to model, and then we can update the PR here so that all the conjugations will have appropriate setups.

}
}

/// What the conjugation state is for the conjugate feature.
enum HEConjugationState {
case present
case presSimp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here we'll need to update this list based on what conjugations we'll get from Wikidata :)

func heConjugationStateLeft() {}
func heConjugationStateLeft() {
switch heConjugationState {
case .present, .presSimp, .presCont, .presPerf, .presPerfCont, .pastCont:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should specifically only have one tense for each case statement :)

@andrewtavis
Copy link
Member

Do you want to continue on this issue now, @DanielGevaZA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants