Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/typos in bridge store #1298

Open
wants to merge 687 commits into
base: sepolia
Choose a base branch
from
Open

Fix/typos in bridge store #1298

wants to merge 687 commits into from

Conversation

betrayalove
Copy link

PR Summary

This Pull Request addresses several improvements in the BridgeStore:

-- Fixed a typo: withDrawStep renamed to withdrawStep for consistency with camelCase naming conventions.
-- Added missing types to function parameters for better TypeScript support and code clarity.
These changes enhance code readability and prevent potential issues related to inconsistent variable names.

Checklist

  • There are breaking changes
  • I've added/changed/removed ENV variable(s)
  • I checked whether I should update the docs and did so by updating /docs

Description

This PR fixes two main issues in the BridgeStore code:

  1. withDrawStep → withdrawStep: Renamed to ensure consistency with camelCase naming conventions.
  2. Added missing types: Added types for function parameters like changeHistoryVisible, changeFromNetwork, and others to ensure type safety.
    These changes don't affect the functionality but improve the developer experience by ensuring better naming practices and type safety.

Holybasil and others added 30 commits July 12, 2024 13:13
@Holybasil
fix: coupon -> invite
97633bf
@Holybasil
fix: allow attestByDelegation
2c1e907
@Holybasil
fix: define badges && env
cff4d6f
@Holybasil
fix: customise display badge
3e25c8c
@Holybasil
test: Ethereum Year Badge
abfeb8d
@Holybasil
fix: check eligibility && get recipient by badgeId
5740a6d
@Holybasil
fix: adjust onboarding style
5813512
@Holybasil
fix: first badge animation
c4dcf41
@Holybasil
fix: env
17fdb9f
@Holybasil
fix: mint to canvas
505c60f
@Holybasil
fix: first mint && just view canvas
cf8690b
@Holybasil
fix: center badge detail
0cdf783
@Holybasil
fix: add Cog Finance badge
a680287
@Holybasil
fix: log error
04e8f7b
@Holybasil
fix: remove minted badge
196d3ca
@Holybasil
fix: refresh badge eligibility
8d25139
@Holybasil
fix: typo
8ffa71d
@zzq0826 @Holybasil
use signer for queryFirstMintUsername
d676ea4
@zzq0826 @Holybasil
Update copies
e77c6e2
@zzq0826 @Holybasil
add zebra canvas
c2f4e49
@zzq0826 @Holybasil
Update zebra address
1829e7d
@zzq0826 @Holybasil
add log
fba6e78
@zzq0826 @Holybasil
update ethers
f1a32eb
@zzq0826 @Holybasil
improve style
c5efc0c
@zzq0826 @Holybasil
improve style
b682e25
@zzq0826 @Holybasil
improve style
f524dc2
@zzq0826 @Holybasil
improve canvas style
e08c66b
@Holybasil
fix: scroll button style
fe3e59a
@Holybasil
fix: canvas mobile version
e682c4e
@Holybasil
fix: mobile ecosystem badges
b04a8a3
zzq0826 and others added 28 commits August 26, 2024 20:39
@zzq0826
Update cover image
6a0ec6e
@yqrashawn
chore(blog): fetch blog/data.json with origin (scroll-tech#1263)
f2497bf
@zzq0826
Add community page (scroll-tech#1169)
8dabb11 
* Add community page

* Fix search params

* Adjust mobile style

* Update link

* Fix label

* Adjust style

* Adjust styles

* Add og image

* Adjust camera position

* Adjust style
@zzq0826
Update netlify (scroll-tech#1266)
4552ac6 
* Update config
@Holybasil
fix: allow new tab
7bb0803
@Holybasil
fix: no back on new tab
705a086
@Holybasil
Merge pull request scroll-tech#1270 from scroll-tech/badge-link
4380769 
fix: allow new tab
@yqrashawn
fix: fetch token price only at /bridge.* (scroll-tech#1272)
46c4c91 
Signed-off-by: yqrashawn <[email protected]>
@zzq0826
Fix: Use BigInt for handling large numbers to avoid scientific notation.
5a2cda0
@zzq0826
Merge pull request scroll-tech#1274 from scroll-tech/fix-bridge-history
3e2e0b3 
Fix: Use BigInt for handling large numbers to avoid scientific notation.
@Holybasil
doc: add canvas doc
17bfbd6
@Holybasil
fix: update canvas doc
6ab2c45
@Holybasil
fix: update content
3b3581b
@Holybasil
Merge pull request scroll-tech#1276 from scroll-tech/add-canvas-doc
7bb92a3 
doc: add canvas doc
@Holybasil
fix: ecosystem metrics
ce7c593
@Holybasil
Merge pull request scroll-tech#1278 from scroll-tech/ecosystem-metrics
bd78541 
fix: ecosystem metrics
@zzq0826
Fix Economy Deposit (scroll-tech#1281)
7e4d9b4
@zzq0826
Update copy (scroll-tech#1283)
7ed3d6a 
* Update copy

* Update style

* Adjust font size
@Holybasil
fix: issuer of upgradable badge
6f33cd2
@Holybasil
fix: remove item click
a789d83
@Holybasil
Merge pull request scroll-tech#1285 from scroll-tech/upgradable-badge…
11d6404 
…-issuer

Upgradable badge issuer
@zzq0826 @hyperchris123
Adjust globe json path (scroll-tech#1287)
0e5fa27 
Co-authored-by: Sourav Gupta <[email protected]>
@Holybasil
fix: display total tx count
807671a
@Holybasil
Merge pull request scroll-tech#1289 from scroll-tech/ecosystem-tx-count
aa4caea 
fix: display total tx count
@zzq0826 @Holybasil
Add more assets (scroll-tech#1293)
39b7456 
* Add more assets

* Update Mitosis link

* Add logo for Mitosis

* fix: project url

* Update openblock api

* adjust find token logic

---------

Co-authored-by: holybasil <[email protected]>
@betrayalove
fix: rename parameter in fetchCanvasDetail from privider to provider
9742110
@betrayalove
fix: correct typos in depositType and depositAmountIsValid in BatchBr…
83ff1f3 
…idgeStore
@betrayalove
fix: correct typos and add missing types in BridgeStore
d431644
@Holybasil Holybasil force-pushed the sepolia branch 2 times, most recently from 5975871 to b86453d Compare December 26, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betrayalove @Holybasil @zzq0826 @yqrashawn