Fix/add types and fix typos #1299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add community page * Fix search params * Adjust mobile style * Update link * Fix label * Adjust style * Adjust styles * Add og image * Adjust camera position * Adjust style
* Update config
fix: allow new tab
Signed-off-by: yqrashawn <[email protected]>
Fix: Use BigInt for handling large numbers to avoid scientific notation.
doc: add canvas doc
fix: ecosystem metrics
* Update copy * Update style * Adjust font size
…-issuer Upgradable badge issuer
Co-authored-by: Sourav Gupta <[email protected]>
fix: display total tx count
* Add more assets * Update Mitosis link * Add logo for Mitosis * fix: project url * Update openblock api * adjust find token logic --------- Co-authored-by: holybasil <[email protected]>
Holybasil
force-pushed
the
sepolia
branch
2 times, most recently
from
5975871 to
b86453d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Missing type annotations in many functions, which reduced type safety and could lead to runtime errors.
Usage of any type, which compromised the clarity and type security of the codebase.
Typos in variable names, which decreased code readability and could cause confusion.
The solution includes:
Addition of proper TypeScript types to all functions and their parameters.
Replacing any with more precise types like Contract, string, and boolean.
Correcting typos in variable names to improve code readability and prevent potential errors.
Checklist
/docsDescription
Key Changes:
TypeScript types were added to functions that were previously missing type annotations. This includes functions dealing with contracts, strings, and boolean values.
All instances of the any type were replaced with more specific types like Contract, string, and boolean to enhance type safety and clarity.
Variable name typos were corrected (e.g., privider → provider), which improves code readability and reduces the risk of errors.
The logic in certain functions was refactored for better readability and maintainability. The code is now more comprehensible and easier to work with, thanks to stricter typing and the correction of naming inconsistencies.
Reasons for the Changes:
These changes are necessary to improve the overall type safety of the codebase, enhance code readability, and prevent potential issues caused by missing type annotations or improper variable names.
Improving the maintainability of the code is crucial, especially as the project grows and more developers contribute to it.