Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] upstream inverse acceleration #10

Merged
merged 3 commits into from
Aug 17, 2024
Merged

[sync] upstream inverse acceleration #10

merged 3 commits into from
Aug 17, 2024

Conversation

Velaciela
Copy link

Description:

From snarkify merkle circuit example (comparison),
we find that the performance of the poseidon hash in the Scroll version has a gap compared to the upstream.

And it turns out that the inverse() operation is the main bottleneck.

related PR

This PR cherry-picked several performance-optimizing PRs from upstream:

performance

before

Start: kzg k_table_size=18 repeat_count=10
··Start: keygen
··End: keygen............................................................175.00s
··Start: prove
··End: prove.............................................................106.00s
··Start: verify
··End: verify..............................................................0.01s
End: kzg k_table_size=18 repeat_count=10.................................290.00s

after

Start: kzg k_table_size=18 repeat_count=10
··Start: keygen
··End: keygen.............................................................40.40s
··Start: prove
··End: prove..............................................................38.80s
··Start: verify
··End: verify..............................................................0.01s
End: kzg k_table_size=18 repeat_count=10..................................89.10s

mratsim and others added 3 commits August 14, 2024 09:20
…s#83)

* Bernstein yang modular multiplicative inverter (#2)

* rename similar to privacy-scaling-explorations#95

---------

Co-authored-by: Aleksei Vambol <[email protected]>
…rivacy-scaling-explorations#95)

* Derivatives of the Pornin's method (taikoxyz#3)

* renaming file

* make cargo fmt happy

* clarifications from privacy-scaling-explorations#95 (comment) [skip ci]

* Formatting and slightly changing a comment

---------

Co-authored-by: Aleksei Vambol <[email protected]>
@lispc lispc changed the base branch from use_pairing to v0.1.0 August 17, 2024 12:14
@lispc lispc merged commit a495a7b into v0.1.0 Aug 17, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants