Implement pairing traits from crate #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roynalnaruto
approved these changes
Aug 13, 2024
| @@ -1,5 +1,6 @@ | |||
| mod arithmetic; | |||
| pub mod hash_to_curve; | |||
| // TODO: remove this and use traits defined in axiom_pairing instead. | |||
There was a problem hiding this comment.
Would this be done in a separate PR? If yes, can we file an issue for this task to keep a track?
There was a problem hiding this comment.
I don't think we have issues enabled on this repo and I cannot see a way for me to enable them. I assume I don't have the right permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use axiom's community edition snark-verifier, we need to implement these traits again because axiom has migrated the pairing traits into an independent crate.