types: Implement API functions for duration type

[muzarski]

This PR implements following set of API functions related to duration type:

• cass_statement_bind_duration_*
• cass_user_type_set_duration_*
• cass_tuple_set_duration
• cass_value_get_duration
• cass_value_is_duration
• cass_collection_append_duration

Pre-review checklist

• I have split my patch into logically separate commits.
• All commit messages clearly explain what they change and why.
• PR description sums up the changes and reasons why they should be introduced.
• [ ] I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
• [ ] I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

[muzarski]

@Lorak-mmk @wprzytula Do you know how to enable the tests for the duration type? I see there is a tests/src/integration/values/duration.hpp file but I'm not sure how to enable it in CI.

[muzarski]

@Lorak-mmk @wprzytula Do you know how to enable the tests for the duration type? I see there is a tests/src/integration/values/duration.hpp file but I'm not sure how to enable it in CI.

I see that the duration tests were run in CI: 12 tests from CassandraTypes/CassandraTypesTests/7, where TypeParam = test::driver::NullableValue<test::driver::values::Duration>. I'm curious why Decimal tests are not being run (decimal is unimplemented type).

[Lorak-mmk]

@Lorak-mmk @wprzytula Do you know how to enable the tests for the duration type? I see there is a tests/src/integration/values/duration.hpp file but I'm not sure how to enable it in CI.

To be honest I'm not sure how those tests work. I can see that both duration and decimal have some special handling.
Those tests are defined in tests/src/integration/tests/test_cassandra_types.cpp
I can see that there is some specialization for Duration:

cpp-rust-driver/tests/src/integration/tests/test_cassandra_types.cpp

Line 98 in 805ef4c

class CassandraTypesDurationTests : public CassandraTypesTests<Duration> {};

And later some registration for types excluding duration:

cpp-rust-driver/tests/src/integration/tests/test_cassandra_types.cpp

Lines 884 to 891 in 805ef4c

	// Register all parameterized test cases for primitives (excludes duration)
	REGISTER_TYPED_TEST_CASE_P(CassandraTypesTests, Integration_Cassandra_Basic,
	Integration_Cassandra_ByName, Integration_Cassandra_NamedParameters,
	Integration_Cassandra_NullValues, Integration_Cassandra_NullList,
	Integration_Cassandra_NullMap, Integration_Cassandra_NullSet,
	Integration_Cassandra_List, Integration_Cassandra_Set,
	Integration_Cassandra_Map, Integration_Cassandra_Tuple,
	Integration_Cassandra_UDT);

There is also some instantiation that includes decimal:

cpp-rust-driver/tests/src/integration/tests/test_cassandra_types.cpp

Lines 925 to 930 in 805ef4c

	// Instantiate the test case for all the Cassandra data types
	typedef testing::Types<Ascii, BigInteger, Blob, Boolean, Date, Decimal, Double, Duration, Float,
	Inet, Integer, SmallInteger, Text, Time, Timestamp, TimeUuid, TinyInteger,
	Uuid, Varchar, Varint>
	CassandraTypes;
	INSTANTIATE_TYPED_TEST_CASE_P(CassandraTypes, CassandraTypesTests, CassandraTypes);

[Lorak-mmk]

@Lorak-mmk @wprzytula Do you know how to enable the tests for the duration type? I see there is a tests/src/integration/values/duration.hpp file but I'm not sure how to enable it in CI.

I see that the duration tests were run in CI: 12 tests from CassandraTypes/CassandraTypesTests/7, where TypeParam = test::driver::NullableValue<test::driver::values::Duration>. I'm curious why Decimal tests are not being run (decimal is unimplemented type).

Where do you see that? I don't see any occurence of decimal or duration in CI logs.

[muzarski]

@Lorak-mmk @wprzytula Do you know how to enable the tests for the duration type? I see there is a tests/src/integration/values/duration.hpp file but I'm not sure how to enable it in CI.

I see that the duration tests were run in CI: 12 tests from CassandraTypes/CassandraTypesTests/7, where TypeParam = test::driver::NullableValue<test::driver::values::Duration>. I'm curious why Decimal tests are not being run (decimal is unimplemented type).

Where do you see that? I don't see any occurence of decimal or duration in CI logs.

build job, step Run integration tests on Scylla 5.0.0, line 577

[Lorak-mmk]

I see. Ctrl + f seems to be quite unreliable in those logs...

[muzarski]

v2: rebased on master

[muzarski]

v3:

• rebased on master
• addressed minor issues
• fixed cass_value_is_duration and cass_value_is_collection
• making use of rust-driver's builtin serialization for simple types (first commit).

[muzarski]

v3.1: rebased on master

[Lorak-mmk]

One more question: before you mentioned some tests that were incorrectly skipped. Is that fixed now?

[muzarski]

One more question: before you mentioned some tests that were incorrectly skipped. Is that fixed now?

Yes, there is an issue for that: #144. Do you want me to fix it before merging this PR?

[Lorak-mmk]

It can be a separate PR - but I don't want to postpone it too long.