pkg: fix deb package building and extend CI #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building debian packages a lot of errors occur. After investigation, it seems that happens due to `dh` (debhelpers, see https://manpages.debian.org/testing/debhelper/dh.1.en.html) treating the top-level Makefile as build tool for some steps. The top-level Makefile was created only for testing/CI purposes. When building packages, we should make use of cmake - this is exactly what this commit does.
muzarski
force-pushed
the
fix-pkg-dh-buildsystem
branch
10 times, most recently
from
53884b7
to
b7edf31
Compare
muzarski
force-pushed
the
fix-pkg-dh-buildsystem
branch
8 times, most recently
from
b2a2d6a
to
1fd54cf
Compare
Since changes such as introducing a top-level Makefile can cause a failure during building packages, we will extend our CI to test that we can successfully build packages after introducing some changes in the future.
muzarski
force-pushed
the
fix-pkg-dh-buildsystem
branch
from
1fd54cf
to
25d5d53
Compare
Merged
wprzytula
approved these changes
Oct 3, 2024
Lorak-mmk
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue that occurred during deb packages build.
Extended CI by pkg build checks - after future changes, we want to make sure that building packages still works as expected.
In CI, I included builds for 4 distributions (that we've chosen for recent release):
Please, let me know if I should include builds for some other distros as well.
Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[ ] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[ ] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.