cluster: keepalive config options #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In following commits, we will adjust the defaults according to `cassandra.h`. It will be much clearer if we define all defaults in nested scope.
Some of them are already set like this in rust-driver by default, but it does not hurt us to set them here as well, in case something changes in rust-driver.
Sets the defaults, and implements: - cass_cluster_set_connection_heartbeat_interval - cass_cluster_set_connection_idle_timeout
wprzytula
approved these changes
Oct 16, 2024
Lorak-mmk
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config defaults
Adjusted the config defaults for some options that were already supported by cpp-rust-driver.
keepalive
Implemented
cass_cluster_set_connection_heartbeat_intervalandcass_cluster_set_connection_idle_timeout.Set the defaults for these options.
HeartbeatTests
HeartbeastTests suite unfortunately cannot be enabled yet. It depends on logs emitted by the driver. However, we will be able to enable most of them, see scylladb/scylla-rust-driver#1092. The only exception is
HeartbeatTests.Integration_Cassandra_HeartbeatFailedsince it requires metrics support as well.Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.