Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adjust and enable heartbeat tests #202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

muzarski
Copy link
Collaborator

@muzarski muzarski commented Oct 30, 2024

depends on: #200

Enabled:

  • HeartbeatTests.Integration_Cassandra_HeartbeatEnabled
  • HeartbeatTests.Integration_Cassandra_HeartbeatDisabled

HeartbeatTests.Integration_Cassandra_HeartbeatFailed is still disabled, since it requires cass_session_get_metrics to be implemented.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have implemented Rust unit tests for the features/changes introduced.
  • I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

@muzarski muzarski self-assigned this Oct 30, 2024
Adjusted the logger criteria, based on the logs emitted by rust-driver.
Enabled:
- HeartbeatTests.Integration_Cassandra_HeartbeatEnabled
- HeartbeatTests.Integration_Cassandra_HeartbeatDisabled

HeartbeatTests.Integration_Cassandra_HeartbeatFailed is still disabled,
since it required `cass_session_get_metrics` to be implemented.
@muzarski
Copy link
Collaborator Author

Rebased on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants