[.github/workflow/rust.yml] Add docker credentials to avoid rate limit #1091

yaronkaikov · 2024-10-14T19:32:16Z

To avoid errors such

Error toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

we should add a login to our Scylladb docker hub

Adding it

github-actions · 2024-10-14T19:37:21Z

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 8d9993b

Lorak-mmk · 2024-10-15T14:05:28Z

Thanks!

Could you update other jobs too? Those also use docker:

authenticate_test.yml
book.yml
cassandra.yml
tls.yml

yaronkaikov · 2024-10-15T14:56:53Z

Thanks!

Could you update other jobs too? Those also use docker:
authenticate_test.yml
book.yml
cassandra.yml
tls.yml

Added

Lorak-mmk · 2024-10-15T15:09:39Z

.github/workflows/cassandra.yml

      # A separate step for building to separate measuring time of compilation and testing
    - name: Update rust toolchain
      run: rustup update
+      env:
+        DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+        DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
    - name: Build the project
      run: cargo build --verbose --tests --features "full-serialization"


I think you put those env on wrong step, no? The step above ("Setup 3-node Cassandra cluster") uses docker.

Lorak-mmk · 2024-10-15T15:14:59Z

.github/workflows/authenticate_test.yml

    - name: Run tests
      run: RUST_LOG=trace cargo test --verbose authenticate_superuser -- custom_authentication --ignored
+      env:
+        DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+        DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}


This step does not execute docker - instead there is services section in job definition. Probably those credentials need to be there, right? However I'm not sure how to do it. It looks like there is no env section there. according to https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idservicesservice_idcredentials you can use credentials section for that, but it uses password, and I see that you are using token - so I'm not sure how to best solve it, I'm not a docker / Ghitub Actions expert :/

Lorak-mmk · 2024-10-15T15:15:10Z

.github/workflows/book.yml

    - uses: actions/checkout@v3
    - name: Update rust toolchain
      run: rustup update
+      env:
+        DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+        DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
    - name: Install mdbook
      run: cargo install mdbook --no-default-features
    - name: Build the project


Ditto about services section

Lorak-mmk · 2024-10-15T15:15:27Z

.github/workflows/tls.yml

    - uses: actions/checkout@v3
    - name: Update rust toolchain
      run: rustup update
+      env:
+        DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+        DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
    - name: Check
      run: cargo check --verbose --features "ssl"
      working-directory: ${{env.working-directory}}


Ditto about services section.

yaronkaikov · 2024-10-20T05:39:23Z

@Lorak-mmk Address all comments , please review again

Lorak-mmk

Looks fine now. Question: does env key in services describe variables passed to docker command? Description of the key is: Sets a map of environment variables in the service container. - so I thought those are variables set in the container.

dkropachev · 2024-10-29T11:09:28Z

.github/workflows/rust.yml

+      env:
+        DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+        DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}


docker compose won't pick these credentials up, you need to login first:

name: Login to Docker Hub uses: docker/login-action@v3 with: username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }}

dkropachev · 2024-10-29T11:15:50Z

.github/workflows/authenticate_test.yml

+      env:
+        DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+        DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}


Suggested change

env:

DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}

DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}

credentials:

username: ${{ secrets.DOCKERHUB_USERNAME }}

password: ${{ secrets.DOCKERHUB_TOKEN }}

Will token work as password?

Yes, https://docs.docker.com/security/for-developers/access-tokens/#use-an-access-token

dkropachev · 2024-10-29T11:17:21Z

.github/workflows/book.yml

+      env:
+        DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+        DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}


Suggested change

env:

DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}

DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}

credentials:

username: ${{ secrets.DOCKERHUB_USERNAME }}

password: ${{ secrets.DOCKERHUB_TOKEN }}

dkropachev · 2024-10-29T11:17:38Z

.github/workflows/cassandra.yml

+      env:
+        DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+        DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}


Same as https://github.com/scylladb/scylla-rust-driver/pull/1091/files#r1820593853

dkropachev · 2024-10-29T11:18:17Z

.github/workflows/tls.yml

+      DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+      DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}


Suggested change

DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}

DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}

```suggestion

credentials:

username: ${{ secrets.DOCKERHUB_USERNAME }}

password: ${{ secrets.DOCKERHUB_TOKEN }}

To avoid errors such ``` Error toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit ``` we should add login to our Scylladb docker hub Adding it

muzarski requested a review from Lorak-mmk October 15, 2024 11:42

wprzytula added the symptom/ci stability Related to continuous integration label Oct 15, 2024

yaronkaikov force-pushed the add-dockerhub-cred branch from f60a8d3 to b18a4f5 Compare October 15, 2024 14:56

Lorak-mmk requested changes Oct 15, 2024

View reviewed changes

yaronkaikov force-pushed the add-dockerhub-cred branch 2 times, most recently from fd20963 to ef4f21a Compare October 20, 2024 05:38

Lorak-mmk previously approved these changes Oct 21, 2024

View reviewed changes

dkropachev requested changes Oct 29, 2024

View reviewed changes

yaronkaikov dismissed Lorak-mmk’s stale review via da0cdec October 30, 2024 19:12

yaronkaikov force-pushed the add-dockerhub-cred branch from ef4f21a to da0cdec Compare October 30, 2024 19:12

yaronkaikov requested a review from dkropachev October 30, 2024 19:12

yaronkaikov force-pushed the add-dockerhub-cred branch 3 times, most recently from a8961b7 to 319a7f4 Compare October 30, 2024 19:16

yaronkaikov marked this pull request as draft October 30, 2024 19:17

yaronkaikov force-pushed the add-dockerhub-cred branch from 319a7f4 to 1aef293 Compare November 6, 2024 11:13

yaronkaikov marked this pull request as ready for review November 6, 2024 11:13

yaronkaikov force-pushed the add-dockerhub-cred branch 3 times, most recently from 145e14c to 30ff11c Compare November 6, 2024 11:58

yaronkaikov force-pushed the add-dockerhub-cred branch from 30ff11c to 8d9993b Compare November 6, 2024 11:59

Lorak-mmk self-requested a review December 16, 2024 11:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[.github/workflow/rust.yml] Add docker credentials to avoid rate limit #1091

[.github/workflow/rust.yml] Add docker credentials to avoid rate limit #1091

yaronkaikov commented Oct 14, 2024

github-actions bot commented Oct 14, 2024 •

edited

Loading

Lorak-mmk commented Oct 15, 2024

yaronkaikov commented Oct 15, 2024

Lorak-mmk Oct 15, 2024

Lorak-mmk Oct 15, 2024

Lorak-mmk Oct 15, 2024

Lorak-mmk Oct 15, 2024

yaronkaikov commented Oct 20, 2024

Lorak-mmk left a comment

dkropachev Oct 29, 2024

dkropachev Oct 29, 2024

Lorak-mmk Oct 29, 2024

dkropachev Oct 29, 2024

dkropachev Oct 29, 2024

dkropachev Oct 29, 2024

dkropachev Oct 29, 2024

-      env:
-        DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
-        DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
+        credentials:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}

		DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
		DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}

[.github/workflow/rust.yml] Add docker credentials to avoid rate limit #1091

Are you sure you want to change the base?

[.github/workflow/rust.yml] Add docker credentials to avoid rate limit #1091

Conversation

yaronkaikov commented Oct 14, 2024

github-actions bot commented Oct 14, 2024 • edited Loading

Lorak-mmk commented Oct 15, 2024

yaronkaikov commented Oct 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yaronkaikov commented Oct 20, 2024

Lorak-mmk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 14, 2024 •

edited

Loading