Remove unnecessary pub
#497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(non backwards-compatible) Alternately we could make this return an explicit type so that it's expressable, but I doubt that would actually be necessary for anyone. https://github.com/scylladb/scylla-rust-driver/blob/db8d52893bdef56977872a09f51fda2fa423168f/scylla-cql/src/frame/value.rs#L189
wprzytula
added
API-breaking
|
@Ten0 This is ridiculously late response, but could you please rebase this on newest main? We'll graciously merge it. |
wprzytula
approved these changes
Jun 20, 2024
wprzytula
added
the
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(non backwards-compatible)
Alternately we could make this return an explicit type so that it's expressable, but I doubt that would actually be necessary for anyone.
scylla-rust-driver/scylla-cql/src/frame/value.rs
Line 189 in db8d528