codewide: Allow setting Serial,LocalSerial for Consistency #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wprzytula
force-pushed
the
consistency-allows-serial
branch
from
b933939
to
9b820eb
Compare
It appears that, contrary to what we thought, LocalSerial and Serial are also valid values for Consistency in some cases: for LWT SELECTs. Therefore, Consistency is extended with Serial and LocalSerial variants, and LegacyConsistency is removed as no longer making sense.
The test stays there to assert that it is expressible and possible to perform such a query. Before, Consistency did not contain serial variants, so it used to not be feasible, even though supported by Scylla.
wprzytula
force-pushed
the
consistency-allows-serial
branch
from
9b820eb
to
86085c5
Compare
|
piodul
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #736.
What's done
Consistencyis extended withSerialandLocalSerialto support reading using Paxos (SELECT statements),LegacyConsistencyis removed altogether,Fixes: #736
Pre-review checklist
[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.Fixes:annotations to PR description.