Fix popup when a CL doesn't have revisions #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a CL doesn't have revisions, the current revision can't be found and thus we can't retrieve the current revision's description. This CL fixes this by returning null in getDescription() when this happens, and falling back to the change's subject in the CL widget. Fixes sdefresne#52
|
@sdefresne Friendly ping in case you didn't see it (in another PR you mention you didn't receive an email notification for the PR, maybe tagging you sends it :) Thanks in advance! :)) |
sdefresne
requested changes
Mar 8, 2024
| if (currentRevision !== undefined) { | ||
| this.description_ = new Description(currentRevision.commit.message); | ||
| } else { | ||
| this.description_ = null; |
There was a problem hiding this comment.
Could we instead return new Description("")?
IIUC the code, this should be enough and won't require the other changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a CL doesn't have revisions, the current revision can't be found and thus we can't retrieve the current revision's description.
This CL fixes this by returning null in getDescription() when this happens, and falling back to the change's subject in the CL widget.
Fixes #52