Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize articles into more suitable categories #108

Closed

Conversation

luyangkenneth
Copy link
Member

Closes #107 - this PR implements all the suggestions in that issue

@damithc
Copy link
Contributor

damithc commented Mar 21, 2019

Open for peer reviews ...

@luyangkenneth
Copy link
Member Author

I will also announce this later on, so that everyone can fix their merge conflicts (if any) based off this issue/PR.

@damithc
Copy link
Contributor

damithc commented Mar 21, 2019

Should we hold this back until almost all the current articles are in? This structure might even need further tweaks, for example, there are some database topics current WIP.

@luyangkenneth
Copy link
Member Author

I think it'll be less painful to incorporate these changes early. I'm also happy to do another smaller round of tweaks if necessary.

That said, I'm certainly mindful about breaking others' workflows, so I've scanned through all the open issues/PRs, and the number of conflicts I foresee seem to be pretty minimal 😃

I can't seem to find any database-related issues/PRs at the moment - could you point them out to me please?

@damithc
Copy link
Contributor

damithc commented Mar 21, 2019

I can't seem to find any database-related issues/PRs at the moment - could you point them out to me please?

@amrut-prabhu has an article on SQL https://github.com/se-edu/learningresources/pulls/amrut-prabhu

* [HTTPS]({{baseUrl}}/contents/security/Https.html)
* [SQL Injection]({{baseUrl}}/contents/security/sqlInjection.html)
* Software Architecture
* [REST]({{baseUrl}}/contents/softwareArchitecture/RESTArchitecturalStyle.html)
* Static Analysis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Static Analysis be under Code Quality?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think it makes sense - I previously considered it too but didn't feel super compelled at the time. Glad to know that one more person has similar thoughts! I'll go ahead with moving this 🙂

@luyangkenneth
Copy link
Member Author

@damithc - Gotcha, thanks for pointing that out. For @amrut-prabhu's article (like all the other WIP articles), it still falls under the same category, so I don't foresee needing another round of tweaks to the category structure.

Is there anything else that's making you hesitant about going ahead with this reorg?

@damithc
Copy link
Contributor

damithc commented Mar 22, 2019

I think it'll be less painful to incorporate these changes early. I'm also happy to do another smaller round of tweaks if necessary.

It's a choice between one person fixing it in one PR versus many having to fix small parts of it in many PRs :-)

@damithc
Copy link
Contributor

damithc commented Mar 22, 2019

SE Topics -> Software Engineering?

@luyangkenneth
Copy link
Member Author

Okay, I think you have a point there - I'll hold back on this until the end of the sem.

@luyangkenneth
Copy link
Member Author

Update: I'll continue working on this after the last book chapter PR has been merged.

@luyangkenneth
Copy link
Member Author

@damithc This is ready for review :)

@damithc damithc closed this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions for grouping articles in the sidebar
3 participants