Reorganize articles into more suitable categories #108
Conversation
|
Open for peer reviews ... |
luyangkenneth
requested review from
amad-person,
marvinchin,
sijie123 and
Xenonym
|
I will also announce this later on, so that everyone can fix their merge conflicts (if any) based off this issue/PR. |
|
Should we hold this back until almost all the current articles are in? This structure might even need further tweaks, for example, there are some database topics current WIP. |
|
I think it'll be less painful to incorporate these changes early. I'm also happy to do another smaller round of tweaks if necessary. That said, I'm certainly mindful about breaking others' workflows, so I've scanned through all the open issues/PRs, and the number of conflicts I foresee seem to be pretty minimal 😃 I can't seem to find any database-related issues/PRs at the moment - could you point them out to me please? |
@amrut-prabhu has an article on SQL https://github.com/se-edu/learningresources/pulls/amrut-prabhu |
_markbind/navigation/mainNav.md
Outdated
| * [HTTPS]({{baseUrl}}/contents/security/Https.html) | ||
| * [SQL Injection]({{baseUrl}}/contents/security/sqlInjection.html) | ||
| * Software Architecture | ||
| * [REST]({{baseUrl}}/contents/softwareArchitecture/RESTArchitecturalStyle.html) | ||
| * Static Analysis |
There was a problem hiding this comment.
Should Static Analysis be under Code Quality?
There was a problem hiding this comment.
Yeah I think it makes sense - I previously considered it too but didn't feel super compelled at the time. Glad to know that one more person has similar thoughts! I'll go ahead with moving this 🙂
|
@damithc - Gotcha, thanks for pointing that out. For @amrut-prabhu's article (like all the other WIP articles), it still falls under the same category, so I don't foresee needing another round of tweaks to the category structure. Is there anything else that's making you hesitant about going ahead with this reorg? |
It's a choice between one person fixing it in one PR versus many having to fix small parts of it in many PRs :-) |
|
|
|
Okay, I think you have a point there - I'll hold back on this until the end of the sem. |
|
Update: I'll continue working on this after the last book chapter PR has been merged. |
luyangkenneth
force-pushed
the
update-sidebar-categories
branch
from
53d5150
to
a5c3299
Compare
|
@damithc This is ready for review :) |
Closes #107 - this PR implements all the suggestions in that issue