Fix one-line method for anonymous classes #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Nov 21, 2023
| @@ -460,12 +460,18 @@ public function myMethod() | |||
| { | |||
| return; // +3 | |||
| } | |||
| } // -3 | |||
|
|
|||
| public function m1(): void {} // +1 | |||
There was a problem hiding this comment.
please add a test for one-line method in non-anonymous class as well (at least in this test file it is not tested currently)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
============================================
- Coverage 84.02% 84.00% -0.02%
- Complexity 1192 1193 +1
============================================
Files 71 71
Lines 4245 4246 +1
============================================
Hits 3567 3567
- Misses 678 679 +1 ☔ View full report in Codecov by Sentry. |
sebastianbergmann
merged commit a2a845d
into
sebastianbergmann:main
19 of 20 checks passed
|
Thank you both ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1020