Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dill pinning #822

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Update dill pinning #822

merged 3 commits into from
Feb 16, 2024

Conversation

uri-granta
Copy link
Collaborator

@uri-granta uri-granta commented Feb 14, 2024 •
edited
Loading

Related issue(s)/PRs: uqfoundation/dill#647

Summary

Pin dill to <0.3.6 for now, as later versions don't seem to serialise some tensorflow-probability kernels.

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

@uri-granta uri-granta marked this pull request as ready for review February 14, 2024 18:00
khurram-ghani
khurram-ghani approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@khurram-ghani khurram-ghani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@uri-granta uri-granta merged commit 44fd93a into develop Feb 16, 2024
12 checks passed
@uri-granta uri-granta deleted the uri/update_dill_pinning branch February 16, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khurram-ghani khurram-ghani khurram-ghani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-granta @khurram-ghani