Adding Boomkin Capabilities #103
Conversation
|
I will continue to work on this. This is from a few hours worth of work. I just wanted to get a PR open so no one was potentially duplicating any of this effort. I'll continue to push to this branch and update the PR when new chunks of work are completed. |
| override val epBaseStat: SpecEpDelta = spellPowerBase | ||
| override val epStatDeltas: List<SpecEpDelta> = defaultCasterDeltas | ||
|
|
||
| override fun redSocketEp(deltas: Map<String, Double>): Double { |
There was a problem hiding this comment.
I wasn't sure what the purpose of these were actually. I just copied it straight from the warlock destruction spec.
There was a problem hiding this comment.
These are for EP calculation - each socket should have an implementation that reasonably estimates which stat would be put in that socket.
I believe boomies would generally use spelldamage in every socket, so the yellow could probably use that as a basis as well.
| override val hidden: Boolean = true | ||
|
|
||
| override fun modifyStats(sp: SimParticipant): Stats { | ||
| // TODO: is it easier to do this than add the 2% hit on each spell call? |
There was a problem hiding this comment.
I wasn't sure how best to handle these types of things. It felt easier to just update the sims hit rating rather than do additional calculations per spell to add the additional hit percent. I was also trying to prevent confusion between using percents as 0 < pct < 1 and 0 < pct < 100
There was a problem hiding this comment.
It depends on the ability - many talents like this are spell-specific, so they would have to be limited. Since Balance of Power applies to all spells, implementing as generic hit rating is just fine!
| @@ -117,6 +118,10 @@ class SimParticipant(val character: Character, val rotation: Rotation, val sim: | |||
| return this | |||
| } | |||
|
|
|||
| inline fun <reified T: Talent> getTalent(talentName: String): T? { | |||
There was a problem hiding this comment.
We can't use Kotlin reflection or reified types, since it won't translate to the javascript web build.
| const val name = "Wrath of Cenarius" | ||
| } | ||
|
|
||
| override val name: String = Dreamstate.name |
|
|
||
| override fun modifyStats(sp: SimParticipant): Stats { | ||
| // TODO: is it easier to do this than add the 5% crit on each spell call? | ||
| return Stats(spellDamage= (increasedSpellDamagePercentByIntellect() * sp.spellDamage()).toInt()) |
There was a problem hiding this comment.
Should this be increasedSpellDamagePercentByIntellect() * sp.intellect()?
| override val hidden: Boolean = true | ||
|
|
||
| override fun modifyStats(sp: SimParticipant): Stats { | ||
| // TODO: is it easier to do this than add the 5% crit on each spell call? |
| override val hidden: Boolean = true | ||
|
|
||
| override fun modifyStats(sp: SimParticipant): Stats { | ||
| // TODO: is it easier to do this than add the 5% crit on each spell call? |
There was a problem hiding this comment.
Yep! Moonkin form applies to everything, so modeling as generic crit rating is fine!
| const val name = "Moonfire" | ||
| } | ||
|
|
||
| // TODO: lookup this actual value |
| } | ||
|
|
||
| val baseDamage = Pair(305.0, 357.0) | ||
| val baseDot = 600.0 |
There was a problem hiding this comment.
We probably don't need this value in the main ability - it's covered in the DoT implementation
| /** | ||
| * | ||
| */ | ||
| class NaturesReach(currentRank: Int) : Talent(currentRank) { |
There was a problem hiding this comment.
The sim does not take any spell range into consideration, so this talent can probably be omitted.
| /** | ||
| * | ||
| */ | ||
| class Vengeance(currentRank: Int) : Talent(currentRank) { |
There was a problem hiding this comment.
I would recommend implementing this in a similar way to warlock Ruin: https://github.com/marisa-ashkandi/tbcsim/blob/main/src/commonMain/kotlin/character/classes/warlock/talents/Ruin.kt
|
Thanks for the feedback. I'll look into getting in some additional changes this weekend. |
I figured I'd go ahead and open this PR to get some feedback if I'm going in the right direction. I'm interested in getting the boomkin simulator going as that's my main. For the most part, I've been trying to just follow the examples in the warlock talents. I was about to start working on updating the Druid class and wanted to get some feedback on how that should be handled.
@marisa-ashkandi