Fix so preignore properly ignores tests #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During testing, it was found that adding a "tests" to .preignore did not result in the ignoring of that directory in the repo. It seems the path is needed as input to is_ignored() rather than just file name. Also noticed that .git files are getting scanned. Normally they should be ignored as part of .gitignore, but its not typical to include there. Seems Git automatically ignores that directory. So I added it as a global_patterns to IgnoreFilterManager. Also figured that it would be good to include global_ignore_file_paths as was in the example for this class to exclude user defined ignores and repo defined ignores. Signed-off-by: Eric Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing, it was found that adding a "tests" to .preignore did not result in the ignoring of that directory in the repo.
It seems the path is needed as input to is_ignored() rather than just file name.
Also noticed that .git files are getting scanned. Normally they should be ignored as part of .gitignore, but its not typical to include there. Seems Git automatically ignores that directory. So I added it as a global_patterns to IgnoreFilterManager. Also figured that it would be good to include global_ignore_file_paths as was in the example for this class to exclude user defined ignores and repo defined ignores.