Default the assert rule to be disabled #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The point of the assert rule is to catch scenarios where Python builtin assert is used to guard or as a conditional in functions and not realize that running Python with optimizations (-O) would remove those assert statements. However, in practice, its unlikely folks use the optimize compile option as it doesn't provide much "optimization" anyway. Frankly it does very very little. Therefore this change defaults the assert rule to disabled to cut down on noise and probably false positives. Signed-off-by: Eric Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of the assert rule is to catch scenarios where Python builtin assert is used to guard or as a conditional in functions and not realize that running Python with optimizations (-O) would remove those assert statements.
However, in practice, its unlikely folks use the optimize compile option as it doesn't provide much "optimization" anyway. Frankly it does very very little. Therefore this change defaults the assert rule to disabled to cut down on noise and probably false positives.