Export as preset instead of plugin #20
Conversation
| "should": "^7.1.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "jscs": ">= 2.5", |
There was a problem hiding this comment.
I think jscs should also be included here. I know peerDependencies are controversial, but the user must get warned about this kind of stuff, and this is pretty much useless without jscs.
There was a problem hiding this comment.
I agree with you on principle, but the fact that npm@3 still handles peerDependencies in a very disturbing way makes me prefer not keeping this here as I don't think anyone will be using a jscs preset without jscs installed. Not even the owner of the project does that - https://github.com/mrjoelkemp/jscs-preset-mrjoelkemp/blob/master/package.json.
There was a problem hiding this comment.
I guess we can still keep it as part of the installation command at least. Let's move on.
|
Can this be merged @ruiquelhas? |
|
ping @ruiquelhas |
By the way, it looks like even thought
jscs-config-*is supported, the jscs community is leaning towardsjscs-preset-*.Might help with #8.
Closes #2.