Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional wrapping issue in mapToStrings function by explicitly… #24

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix optional wrapping issue in mapToStrings function by explicitly… #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2e2df0
Fix optional wrapping issue in mapToStrings function by explicitedly …
didiergarcia Dec 20, 2023
34d5417
Adding comment for clarity.
didiergarcia Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions Sources/SegmentFirebase/FirebaseDestination.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,19 @@ extension FirebaseDestination {
}

// Makes sure all traits are string based for Firebase API
func mapToStrings(_ mapDictionary: [String: Any], finalize: (String, String) -> Void) {
func mapToStrings(_ mapDictionary: [String: Any?], finalize: (String, String) -> Void) {

for (key, data) in mapDictionary {
var dataString = data as? String ?? "\(data)"
let keyString = key.replacingOccurrences(of: " ", with: "_")
dataString = dataString.trimmingCharacters(in: .whitespacesAndNewlines)
finalize(keyString, dataString)

// Since dictionary values can be Optional we have to unwrap them
// before encoding so that we don't encode them as "Optional(*)"
// Note: nil values are NOT encoded.
if let d = data {
var dataString = d as? String ?? "\(d)"
let keyString = key.replacingOccurrences(of: " ", with: "_")
dataString = dataString.trimmingCharacters(in: .whitespacesAndNewlines)
finalize(keyString, dataString)
}
}
}
}
Expand Down
Loading