Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the consentSettings property so that we can access it directly… #225

Merged
merged 1 commit into from
May 22, 2024

Conversation

didiergarcia
Copy link
Contributor

@didiergarcia didiergarcia commented May 21, 2024

Adding the consentSettings property so that we can access it directly in tests instead of using JSON as workaround.

Downstream projects like analytics-kotlin-consent will now have the ability to set the consentSettings property so that we can add more great tests!

… in tests instead of using JSON as workaround.
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.42%. Comparing base (79cfb46) to head (c3249d9).
Report is 7 commits behind head on main.

Files Patch % Lines
...java/com/segment/analytics/kotlin/core/Settings.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #225      +/-   ##
============================================
- Coverage     78.65%   78.42%   -0.24%     
- Complexity      502      573      +71     
============================================
  Files            78       80       +2     
  Lines          6588     7044     +456     
  Branches        833      890      +57     
============================================
+ Hits           5182     5524     +342     
- Misses          735      814      +79     
- Partials        671      706      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didiergarcia didiergarcia merged commit 3fa098c into main May 22, 2024
10 checks passed
@didiergarcia didiergarcia deleted the add-consentsettings-prop-to-settings-object branch May 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants