Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make storage internal and not publicly accessible. #238

Closed
wants to merge 1 commit into from

Conversation

didiergarcia
Copy link
Contributor

Make analytics.storage internal so that it is not publicly accessible.

While this was out of spec with the other libraries and needed to be fixed, it seems to have been this way since v1.0.0 so we might have people in the wild relying on it.

@didiergarcia
Copy link
Contributor Author

OK, so turns out android/ uses storage to keep track of: device id, app versions, and other things so we can't just make it internal. This will take some refactoring.

Closing this PR. Adding notes the ticket and moving it back to backlog so we tackle this again later when we have to update Storage to allow an in-memory storage option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant