chore: fix tests

segmentio · Aug 15, 2023 · db9da4f · db9da4f
1 parent f03b2f2
commit db9da4f
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 10 deletions.
diff --git a/packages/browser/src/browser/__tests__/cdn.test.ts b/packages/browser/src/browser/__tests__/cdn.test.ts
@@ -1,4 +1,4 @@
-import { AnalyticsBrowser } from '../..'
+import { AnalyticsBrowser, getGlobalAnalytics } from '../..'
 import unfetch from 'unfetch'
 import { createSuccess } from '../../test-helpers/factories'
 import { setGlobalCDNUrl } from '../../lib/parse-cdn'
@@ -45,5 +45,5 @@ it('if CDN is overridden, sets the overridden CDN global variable', async () =>
     writeKey,
     cdnURL: mockCdn,
   })
-  expect(window.analytics._cdn).toBe(mockCdn)
+  expect(getGlobalAnalytics()?._cdn).toBe(mockCdn)
 })
diff --git a/packages/browser/src/browser/__tests__/integration.test.ts b/packages/browser/src/browser/__tests__/integration.test.ts
@@ -23,6 +23,7 @@ import {
   highEntropyTestData,
   lowEntropyTestData,
 } from '../../test-helpers/fixtures/client-hints'
+import { getGlobalAnalytics } from '../..'
 
 let fetchCalls: ReturnType<typeof parseFetchCall>[] = []
 
@@ -200,7 +201,7 @@ describe('Initialization', () => {
           {
             ...xt,
             load: async () => {
-              expect(window.analytics).toBeUndefined()
+              expect(getGlobalAnalytics()).toBeUndefined()
               expect(getCDN()).toContain(overriddenCDNUrl)
             },
           },

diff --git a/packages/browser/src/browser/__tests__/standalone-analytics.test.ts b/packages/browser/src/browser/__tests__/standalone-analytics.test.ts
@@ -1,13 +1,14 @@
 import jsdom, { JSDOM } from 'jsdom'
-import { InitOptions } from '../../'
+import { InitOptions, getGlobalAnalytics } from '../../'
 import { AnalyticsBrowser, loadLegacySettings } from '../../browser'
 import { snippet } from '../../tester/__fixtures__/segment-snippet'
-import { install, AnalyticsStandalone } from '../standalone-analytics'
+import { install } from '../standalone-analytics'
 import unfetch from 'unfetch'
 import { PersistedPriorityQueue } from '../../lib/priority-queue/persisted'
 import { sleep } from '../../lib/sleep'
 import * as Factory from '../../test-helpers/factories'
 import { EventQueue } from '../../core/queue/event-queue'
+import { AnalyticsStandalone } from '../standalone-interface'
 
 const track = jest.fn()
 const identify = jest.fn()
@@ -142,7 +143,7 @@ describe('standalone bundle', () => {
       .mockImplementation((): Promise<Response> => fetchSettings)
     const mockCdn = 'http://my-overridden-cdn.com'
 
-    window.analytics._cdn = mockCdn
+    getGlobalAnalytics()!._cdn = mockCdn
     await loadLegacySettings(segmentDotCom)
 
     expect(unfetch).toHaveBeenCalledWith(expect.stringContaining(mockCdn))
@@ -262,7 +263,7 @@ describe('standalone bundle', () => {
 
     // register is called after flushPreBuffer in `loadAnalytics`
     register.mockImplementationOnce(() =>
-      window.analytics.track('race conditions', { foo: 'bar' })
+      getGlobalAnalytics()?.track('race conditions', { foo: 'bar' })
     )
 
     await install()

diff --git a/packages/browser/src/browser/__tests__/standalone.test.ts b/packages/browser/src/browser/__tests__/standalone.test.ts
@@ -4,6 +4,7 @@ import { LegacySettings } from '..'
 import { pWhile } from '../../lib/p-while'
 import { snippet } from '../../tester/__fixtures__/segment-snippet'
 import * as Factory from '../../test-helpers/factories'
+import { getGlobalAnalytics } from '../..'
 
 const cdnResponse: LegacySettings = {
   integrations: {
@@ -86,11 +87,11 @@ describe('standalone bundle', () => {
     await import('../standalone')
 
     await pWhile(
-      () => window.analytics?.initialized !== true,
+      () => getGlobalAnalytics()?.initialized !== true,
       () => {}
     )
 
-    expect(window.analytics).not.toBeUndefined()
-    expect(window.analytics.initialized).toBe(true)
+    expect(getGlobalAnalytics()).not.toBeUndefined()
+    expect(getGlobalAnalytics()?.initialized).toBe(true)
   })
 })
diff --git a/packages/browser/src/lib/__tests__/parse-cdn.test.ts b/packages/browser/src/lib/__tests__/parse-cdn.test.ts
@@ -51,6 +51,7 @@ it('should return the overridden cdn if window.analytics._cdn is mutated', () =>
   withTag(`
   <script src="https://cdn.segment.com/analytics.js/v1/gA5MBlJXrtZaB5sMMZvCF6czfBcfzNO6/analytics.min.js" />
   `)
+  // @ts-ignore
   ;(window.analytics as any) = {
     _cdn: 'http://foo.cdn.com',
   }
@@ -59,6 +60,7 @@ it('should return the overridden cdn if window.analytics._cdn is mutated', () =>
 
 it('if analytics is not loaded yet, should still return cdn', () => {
   // is this an impossible state?
+  // @ts-ignore
   window.analytics = undefined as any
   withTag(`
   <script src="https://cdn.segment.com/analytics.js/v1/gA5MBlJXrtZaB5sMMZvCF6czfBcfzNO6/analytics.min.js" />