Add ability to use action-destinations from NPM #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 612d815 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
reviewed
May 18, 2023
| @@ -278,7 +284,16 @@ async function loadAnalytics( | |||
|
|
|||
| attachInspector(analytics) | |||
|
|
|||
| const plugins = settings.plugins ?? [] | |||
| const plugins = settings.plugins?.filter( | |||
There was a problem hiding this comment.
Nit: Can we move this plugins filtering stuff from here into registerPlugins()
-
loadAnalyticshas a habit of getting large (it does a lot of different things, it's a god function), so I've been gradually breaking it up into smaller pieces / functions whenever I can. -
registerPluginssignature could be the same, as it's derived fromplugins. (It already has a large signature with some weird stuff ala opts + options?? LOL
zikaari
force-pushed
the
action-destinations-from-npm
branch
from
a00272a
to
175d6f6
Compare
zikaari
force-pushed
the
action-destinations-from-npm
branch
from
175d6f6
to
7a39c69
Compare
|
@zikaari Looks good! CI is failing =) |
silesky
approved these changes
Jul 25, 2023
silesky
reviewed
Jul 27, 2023
zikaari
force-pushed
the
action-destinations-from-npm
branch
from
70adbf6
to
612d815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the other half of segmentio/action-destinations#1276.
This patch just adds the necessary moving parts that will let users bring in action-destinations from NPM.