Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer prompt user for local network access on app launch on macOS Sequoia #363

Merged

Conversation

manavgabhawala
Copy link
Contributor

Calling ProcessInfo.processInfo.hostName causes a new TCC prompt on macOS Sequoia for the user requesting the app be granted local network access. This code path is hit pretty often, typically during app launch. However, nothing in this framework inherently requires local network access, thus by changing the property to ProcessInfo.processInfo.userName instead, any app linking this framework will no longer be forced to prompt for local network access.

@manavgabhawala manavgabhawala force-pushed the manavgabhawala/LocalNetworkPermission branch from fa5761f to cedfa09 Compare September 18, 2024 01:23
@bsneed
Copy link
Contributor

bsneed commented Sep 18, 2024

Thanks @manavgabhawala! Unfortunately, we can't use "username" there as it would compromise part of the login for that machine. It's probably best to remove that override and let the base classes "unknown" value come through. I quick glance didn't show any alternatives that'd produce the same value without the undesirable effect.

If you can do that, I'll merge this PR. Thanks so much!

@manavgabhawala manavgabhawala force-pushed the manavgabhawala/LocalNetworkPermission branch from cedfa09 to 10535d3 Compare September 19, 2024 02:36
@manavgabhawala
Copy link
Contributor Author

@bsneed updated the PR using your recommendation! Thanks

@bsneed
Copy link
Contributor

bsneed commented Sep 19, 2024

thanks so much @manavgabhawala !

@bsneed bsneed merged commit aea14a1 into segmentio:main Sep 19, 2024
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants