Move comment to right spot

segmentio · Oct 21, 2024 · 1e0a564 · 1e0a564
1 parent e041cbb
commit 1e0a564
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/docs/resources/destination_subscription.md b/docs/resources/destination_subscription.md
@@ -74,8 +74,20 @@ resource "segment_destination_subscription" "send_to_webhook" {
 ### Optional
 
 - `model_id` (String) The unique identifier for the linked ReverseETLModel, if this part of a Reverse ETL connection.
+- `reverse_etl_schedule` (Attributes) (Reverse ETL only) The schedule for the subscription being attached to ReverseETL model. (see [below for nested schema](#nestedatt--reverse_etl_schedule))
 
 ### Read-Only
 
 - `action_slug` (String) The URL-friendly key for the associated Destination action.
 - `id` (String) The unique identifier for the subscription.
+
+<a id="nestedatt--reverse_etl_schedule"></a>
+### Nested Schema for `reverse_etl_schedule`
+
+Required:
+
+- `strategy` (String) Strategy supports three modes: PERIODIC, SPECIFIC_DAYS, or MANUAL.
+
+Optional:
+
+- `config` (String) Configures the schedule for the subscription.
diff --git a/docs/resources/reverse_etl_model.md b/docs/resources/reverse_etl_model.md
@@ -68,10 +68,13 @@ resource "segment_reverse_etl_model" "example" {
 - `name` (String) A short, human-readable description of the Model.
 - `query` (String) The SQL query that will be executed to extract data from the connected Source.
 - `query_identifier_column` (String) Indicates the column named in `query` that should be used to uniquely identify the extracted records.
-- `schedule_config` (String) Depending on the chosen strategy, configures the schedule for this model.
-- `schedule_strategy` (String) Determines the strategy used for triggering syncs, which will be used in conjunction with scheduleConfig.
 - `source_id` (String) Indicates which Source to attach this model to.
 
+### Optional
+
+- `schedule_config` (String, Deprecated) Depending on the chosen strategy, configures the schedule for this model.
+- `schedule_strategy` (String, Deprecated) Determines the strategy used for triggering syncs, which will be used in conjunction with scheduleConfig.
+
 ### Read-Only
 
 - `id` (String) The unique identifier for the model.
diff --git a/internal/provider/destination_resource_test.go b/internal/provider/destination_resource_test.go
@@ -138,7 +138,6 @@ func TestAccDestinationResource(t *testing.T) {
 			if req.Method == http.MethodPatch {
 				updated++
 			}
-			// First update is in create to set the reverse etl model id
 			if updated > 0 {
 				payload = `{
 					"data": {

diff --git a/internal/provider/destination_subscription_resource_test.go b/internal/provider/destination_subscription_resource_test.go
@@ -36,6 +36,7 @@ func TestAccDestinationSubscriptionResource(t *testing.T) {
 					}
 				`
 			} else if req.URL.Path == "/destinations/my-destination-id/subscriptions/my-subscription-id" && req.Method == http.MethodPatch {
+				// First update is to set the model id
 				if updated < 1 {
 					payload = `
 					{
@@ -78,6 +79,7 @@ func TestAccDestinationSubscriptionResource(t *testing.T) {
 
 				updated++
 			} else if req.URL.Path == "/destinations/my-destination-id/subscriptions/my-subscription-id" && req.Method == http.MethodGet {
+				// First update is to set the model id
 				if updated <= 1 {
 					payload = `
 						{