Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove snyk, it does not work for this repo and dependabot will do for security #186

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

petedannemann
Copy link
Contributor

@petedannemann petedannemann commented Mar 26, 2024

Snyk has suddenly broke for this repo and we don't understand why. We already use dependabot for vulnerability management so we can just remove snyk and continue with that for now

Example of snyk being broken:
https://github.com/segmentio/topicctl/actions/runs/8382583098/job/23107120074

@petedannemann petedannemann marked this pull request as ready for review March 26, 2024 18:36
@petedannemann petedannemann requested a review from a team as a code owner March 26, 2024 18:36
Copy link
Contributor

@ssingudasu ssingudasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petedannemann petedannemann merged commit b83ceba into master Mar 26, 2024
9 checks passed
@petedannemann petedannemann deleted the remove-snyk branch March 26, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants