Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow cluster labels #188

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: allow cluster labels #188

merged 1 commit into from
Apr 5, 2024

Conversation

petedannemann
Copy link
Contributor

@petedannemann petedannemann commented Apr 5, 2024 •
edited
Loading

Allow adding arbitrary labels to a cluster file, similar to what we can do for topics and ACLs

@petedannemann petedannemann marked this pull request as ready for review April 5, 2024 19:20
@petedannemann petedannemann requested a review from a team as a code owner April 5, 2024 19:20
ssingudasu
ssingudasu approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@ssingudasu ssingudasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petedannemann petedannemann merged commit ad761c7 into master Apr 5, 2024
9 checks passed
@petedannemann petedannemann deleted the allow-cluster-labels branch April 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssingudasu ssingudasu ssingudasu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petedannemann @ssingudasu