Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit of Botan 3.6.0: TPM2 #245

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Audit of Botan 3.6.0: TPM2 #245

merged 1 commit into from
Oct 25, 2024

Conversation

atreiber94
Copy link
Collaborator

See #242

@atreiber94 atreiber94 self-assigned this Oct 23, 2024
reneme
reneme reviewed Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are fine. I'm wondering though, whether the "critical" classification is what we really want. If yes, we should at least incorporate TPM2 into the testspec and testreport (by enabling support for it in the CI of this repo).

@reneme reneme added this to the Botan 3.6.0 milestone Oct 24, 2024
@reneme
Copy link
Collaborator

reneme commented Oct 25, 2024

See also: #248

@reneme reneme merged commit 4deeeca into main Oct 25, 2024
24 of 25 checks passed
@reneme reneme deleted the audit/3_6_0/tpm2 branch October 25, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme reneme approved these changes

Assignees

@atreiber94 atreiber94

Labels
None yet
Projects
None yet
Milestone
Botan 3.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@atreiber94 @reneme