Cryptodoc update for TPM 2.0 Wrapper #250
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
docs/cryptodoc/src/10_tpm.rst
Outdated
| - ``Esys_EvictControl(ctx, key.transient_handle(), sessions, out(handle))`` | ||
| - ``Esys_TR_SetAuth(ctx, key.transient_handle(), auth_value)`` | ||
| - ``key.persistent_handle() = Esys_TR_GetTpmHandle(ctx, key.transient_handle())`` |
There was a problem hiding this comment.
I put in two topics into one suggestions here earlier: Technically it should be m_esys_ctx here instead of ctx
There was a problem hiding this comment.
Huh? It is m_impl->m_ctx which is the same as for the other ESAPI invocations.
There was a problem hiding this comment.
Yes, but this has been abstracted to m_esys_ctx in this documentation (there's no way to see what ctxis based on the Input description of the method documented here.
In the other ESAPI invocations, ctx has been listed as an input (and for the docu I'm fine with not distinguishing between the wrapped and original context)
There was a problem hiding this comment.
Fair point. I'll just add the ctx as an input value. Technically, this would be the this pointer here, I believe that's why I left it out of the inputs. But that might not be obvious at all.
I think, we should definitely abstract from the context's inner handles here.
Co-Authored-By: Amos Treiber <[email protected]>
Closes #248