-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.0.2-alpha #66
v0.0.2-alpha #66
Conversation
coveraged download_stable_zip_screen to 91%
standartized some procedures on some download screens
added a EventLoop.exit method at the end of each tests in pytest teardown_class
added setup steps for MacOS on README.md updated some modules
TODO: fix some tests TODO: fix some graphics
TODO: fix wiper tests
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am genuinely impressed with how quickly you accomplished the task of translating the entire application from one language/platform to another. Not only that, but you've also implemented numerous improvements along the way. You managed the added complexity of ensuring compatibility with various OS species and subspecies, as well as handling translations, with great skill.
While I initially thought that some areas could be simplified using a more "Pythonic" approach, I now see the value in the setters and getters you incorporated from JavaScript. These likely contributed to the stability of this complex project.
I think we could move one, maybe do a draft release, and you could invite some people in Telegram to test first?
Congratulations on a job well done, GUI!
fixed codebase to fit this change fixed tests to fit this change
I cant did that withou the team. You, @tadeubas and @jdlcdl helped a lot!
At first time, i didnt like it to. But since i remove any
I just made the fix with NotoSans fonts. I will do a final test on OS and wait for @tadeubas /@JDCDL review/approval to tag it and do a release.
<3 |
This is an enormous project, and this particular pr showing the evolution from one base to another is epic. I don't have a formal education in programming, but if I did, I'd expect this code-base and its evolution to be a text-book example on how-to attack and maintain a long-lived project. This project and the process of how it has evolved touches on many important aspects of development, treating each one in a clean manner, without cutting corners, and done so with a mission-critical degree of care. As a reference for good practices, I'll refer back to this project in the future. Beyond the implementation that krux-installer has become, it's most important benefit is to the users, who will be able to install Krux in a safe manner learning all the while. It makes the critically important process of safely installing software simple and clear, and it's a pleasurable experience from start to finish. |
This really a surprise.
Thanks for kind words, it can't be achieved without you, @odudex and @tadeubas in which took some of your firmware time to pay attention to the installer. Also, I repeatedly needed to see the firmware code (especially the tests), from which I learned a lot. The krux code, PRs and issues are a whole formal course.
May this be eternal while it lasts! |
Traduit par Jeanne Do et Jeannette Do
…rd to tadeubas suggestions
fixed underline text for selectable text on verify_stable_zip_screen
Description
Electron deprecated, long live kivy! Major update to python code base:
nodejs
topython
;electron
tokivy
;ktool
from its source;ktool
from its source;What is the purpose of this pull request?