-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: finalhandler #1141
base: master
Are you sure you want to change the base?
chore: finalhandler #1141
Conversation
/cc @dougwilson Can you look? Thank you
|
I am taking a look now to get this released asap |
It is not clear what changes are all in these finalhandler releases. I opened pillarjs/finalhandler#63 to get some clarity and will get this fully updated when I hear back 👍 . Most everything is ready to go here, however. |
As I can undestand by commit's history it is - https://github.com/pillarjs/finalhandler/blob/master/HISTORY.md#v121--2024-09-02 + Full HTTP/2 support without deprecation messages |
I see you updated to 1.3.0 here but there is a 1.3.1 too. Should we update to that / what is in 1.3.1? I could not even find any commit in the report where 1.3.1 is in the package.json so I'm really confused what is going on there and my alarm bells in ym head are going off with what has happened in the past to projects upgrading, which is why I pin deps and review what exactly is being shipped out. |
@dougwilson I see, let's wait for an answer, if there is none I will research the commit history and write it here, but I agree that versions should not be missed |
@dougwilson Okay, let's finish it 😄 I was learning about changes between 1.3.0 and 1.3.1 - and it is - pillarjs/finalhandler@dede5aa, apparently the commits were not sent and the release was made locally, I will try to update |
CI pass ⭐ |
Full HTTP/2 support without deprecation messages
Ref: pillarjs/finalhandler#53