Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: finalhandler #1141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexander-akait
Copy link
Contributor

@alexander-akait alexander-akait commented Sep 3, 2024

Full HTTP/2 support without deprecation messages

Ref: pillarjs/finalhandler#53

@alexander-akait
Copy link
Contributor Author

alexander-akait commented Sep 26, 2024

/cc @dougwilson Can you look? Thank you

nyc has a breaking change, and stop working on Node.js@8 and Node.js@9

@dougwilson
Copy link
Contributor

I am taking a look now to get this released asap

@dougwilson
Copy link
Contributor

It is not clear what changes are all in these finalhandler releases. I opened pillarjs/finalhandler#63 to get some clarity and will get this fully updated when I hear back 👍 . Most everything is ready to go here, however.

@alexander-akait
Copy link
Contributor Author

As I can undestand by commit's history it is - https://github.com/pillarjs/finalhandler/blob/master/HISTORY.md#v121--2024-09-02 + Full HTTP/2 support without deprecation messages

@dougwilson
Copy link
Contributor

I see you updated to 1.3.0 here but there is a 1.3.1 too. Should we update to that / what is in 1.3.1? I could not even find any commit in the report where 1.3.1 is in the package.json so I'm really confused what is going on there and my alarm bells in ym head are going off with what has happened in the past to projects upgrading, which is why I pin deps and review what exactly is being shipped out.

@alexander-akait
Copy link
Contributor Author

@dougwilson I see, let's wait for an answer, if there is none I will research the commit history and write it here, but I agree that versions should not be missed

@alexander-akait
Copy link
Contributor Author

@dougwilson Okay, let's finish it 😄 I was learning about changes between 1.3.0 and 1.3.1 - and it is - pillarjs/finalhandler@dede5aa, apparently the commits were not sent and the release was made locally, I will try to update v1.3.1, looks safe - https://github.com/pillarjs/encodeurl/releases/tag/v2.0.0 (no issues - https://github.com/pillarjs/encodeurl/issues)

@alexander-akait
Copy link
Contributor Author

CI pass ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants