Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mask tasks #33

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Move mask tasks #33

merged 4 commits into from
Sep 5, 2023

Conversation

mlubej
Copy link
Contributor

@mlubej mlubej commented Sep 4, 2023

No description provided.

@mlubej mlubej changed the title Move mask-related tasks from extras Move mask tasks Sep 4, 2023
@mlubej
Copy link
Contributor Author

mlubej commented Sep 5, 2023

Another comment:

  • the Theia snow mask uses the resize_images function from eolearn.mask.utils, which also uses the map_over_axis, located in the same file. On one hand, these functions seems generic and could be useful, on the other, they are not used anywhere else yet, and for resizing we have a dedicated task anyway..

so.. we could also move the utils here, or leave them in eo-learn, albeit unused...

@zigaLuksic
Copy link
Contributor

Another comment:

* the Theia snow mask uses the `resize_images` function from `eolearn.mask.utils`, which also uses the `map_over_axis`, located in the same file. On one hand, these functions seems generic and could be useful, on the other, they are not used anywhere else yet, and for resizing we have a dedicated task anyway..

so.. we could also move the utils here, or leave them in eo-learn, albeit unused...

eolearn.core.utils.common._apply_to_spatial_axes

@mlubej
Copy link
Contributor Author

mlubej commented Sep 5, 2023

moved over also the utils

@zigaLuksic zigaLuksic merged commit cbb2b52 into main Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants