Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move io tasks #34

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Move io tasks #34

merged 4 commits into from
Sep 5, 2023

Conversation

mlubej
Copy link
Contributor

@mlubej mlubej commented Sep 4, 2023

There is one more task which I have not ported, the SentinelHubSen2corTask. I think it pulls in too much code for a very simple thing, which is now easier achievable with the new code, so IMHO the SentinelHubSen2corTask has become redundant and I would just deprecated/remove it in eo-learn.

@mlubej mlubej changed the title add io related extra tasks from eo-learn Move io tasks Sep 4, 2023
Copy link
Contributor

@zigaLuksic zigaLuksic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also include the GeoDBVectorImportTask here? it's in io.extras, which is why we probably missed it

@mlubej
Copy link
Contributor Author

mlubej commented Sep 5, 2023

Could you also include the GeoDBVectorImportTask here? it's in io.extras, which is why we probably missed it

added.

also, @batic, I moved the Meteoblue related tasks, but I only found them used in the https://github.com/sentinel-hub/eo-learn-examples/blob/08f8bb349efc47595b7d7525403c36265ed5cfe4/GEM-data/weather-data.ipynb notebook, so it was a simple change.

@mlubej mlubej requested a review from batic September 5, 2023 10:52
@mlubej mlubej merged commit 82028c2 into main Sep 5, 2023
1 check passed
@mlubej mlubej deleted the move-io-to-extras branch September 5, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants