Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy issue which causes failing build #704

Closed
wants to merge 2 commits into from
Closed

Fix mypy issue which causes failing build #704

wants to merge 2 commits into from

Conversation

mlubej
Copy link
Contributor

@mlubej mlubej commented Jul 21, 2023

Mypy complained about the provided Booster class when it was used in place of the custom ClassifierType Protocol. Since the Booster class in principle corresponds to the ClassifierType protocol, I just manually cast the former to the latter.

@mlubej
Copy link
Contributor Author

mlubej commented Jul 21, 2023

LightGBM V4 was released last week, causing some issues when using older models (even Boosters!)

adding to this PR also the constraint for lightgbm<4.0.0

@mlubej
Copy link
Contributor Author

mlubej commented Jul 21, 2023

There are still failing tests under core/eolearn/tests/test_eoexecutor.py, but I can't reproduce them locally, even with a fresh environment.

@mlubej mlubej closed this Jul 25, 2023
@zigaLuksic zigaLuksic deleted the fix-mypy-issue branch July 25, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlubej