Fix(ci): Move problem tests purely to cargo make test
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few tests are routinely failing on CI because they explicitly hit YouTube URLs, even if the content in question is CC-licensed. This PR simply adds the `#[ignore]` attribute, and adds the `--include-ignored` flag to `cargo make test` so that correct WebM parsing behaviour can be locally verified. We could go a bit further and conditionally ignore the tests based on CI-specific ENV vars, but that's probably overkill given the scope of the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests are routinely failing on CI because they explicitly hit YouTube URLs, even if the content in question is CC-licensed. This PR simply adds the
#[ignore]attribute, and adds the--include-ignoredflag tocargo make testso that correct WebM parsing behaviour can be locally verified.We could go a bit further and conditionally ignore the tests based on CI-specific ENV vars, but that's probably overkill given the scope of the issue.