Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#222] Prevent progress bar rendering from abort #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#222] Prevent progress bar rendering from abort #269

wants to merge 2 commits into from

Commits on Aug 31, 2023

  1. [Chore] Remove unnecessary LANGUAGE pragmas

    @aeqz
    aeqz committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    297324c View commit details
    Browse the repository at this point in the history

  2. [#222] Prevent progress bar rendering from abort 

    Problem: It seems that the current progress bar rendering action is not
completely protected against exceptions.

Solution: As it is an action that runs for a short amount of time and we
really want it to not be interrputed, we can wrap it with
uninterruptibleMask. The resulting rendering loop also gets simpler with
this change.
    @aeqz
    aeqz committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    202706e View commit details
    Browse the repository at this point in the history