boulder/data: Ensure split-machine-functions are disabled in bolt flags #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split-machine-functions is an optional flag for PGO optimize builds that uses the profile data to split hot/cold/unlikely .text sections. Although disabled by default, BOLT does it's own version of splitting hot/cold .text which split-machine-functions gets in the way of.
- Do not use deprecated options - Enable PLT optimizations - Enable peephole optimizations - Change split-stragegy to cdsplit - Update debug functions now DWARF5 is well supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split-machine-functions is an optional flag for PGO optimize builds that uses the profile data to split hot/cold/unlikely .text sections.
Although disabled by default, BOLT does it's own version of splitting hot/cold .text which split-machine-functions gets in the way of.