Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper to dump the current JS stack. #543

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add helper to dump the current JS stack. #543

wants to merge 1 commit into from

Conversation

jdm
Copy link
Member

@jdm jdm commented Dec 20, 2024

This is implemented in C++ due to the use of UniqueChars, which has nontrivial C++ construction/.destruction logic associated with it.

sagudev
sagudev approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@sagudev sagudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs mozjs-sys version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagudev sagudev sagudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdm @sagudev