Ignore set_scheme when input contains trailing/leading C0 controls #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CYBAI
force-pushed
the
avoid-trim-c0-scheme
branch
from
d330e70 to
cbc1b50
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 82.74% 82.72% -0.02%
==========================================
Files 20 20
Lines 3303 3305 +2
==========================================
+ Hits 2733 2734 +1
- Misses 570 571 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
valenting
requested changes
Feb 28, 2023
CYBAI
force-pushed
the
avoid-trim-c0-scheme
branch
2 times, most recently
from
806225f to
f6aaf80
Compare
CYBAI
force-pushed
the
avoid-trim-c0-scheme
branch
from
f6aaf80 to
9c16caa
Compare
CYBAI
changed the title
valenting
requested changes
Mar 6, 2023
| @@ -2313,6 +2313,12 @@ impl Url { | |||
| /// ``` | |||
| #[allow(clippy::result_unit_err, clippy::suspicious_operation_groupings)] | |||
| pub fn set_scheme(&mut self, scheme: &str) -> Result<(), ()> { | |||
| // If the given scheme contains leading or trailing C0 controls, | |||
| // we'll ignore the set_scheme operation. | |||
| if scheme.trim_matches(|ch| ch <= ' ').len() != scheme.len() { | |||
There was a problem hiding this comment.
There are two problems here:
- I think we should early exit if the scheme
containsa Non-tab/newline C0 controls - not just leading or trailing - This would still match tabs and newlines.
Please add a test for one of these chars in the middle of the scheme.
Also a test that setting it to https\n still works.
|
☔ The latest upstream changes (presumably 1158370) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use the
parser::Input::new, it will initialize the input iterator with trimming both whitespaces and C0 controls. However, for scheme, we should only trim whitespaces. Thus, with moving from::newto::trim_tab_and_newlinescould fix the issue.This PR will fix #815.