Support exporting pem from Certificate
#282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as the underlying security-framework crate doesn't implement PEM exporting yet
sfackler
reviewed
Nov 9, 2023
| @@ -225,6 +225,10 @@ impl Certificate { | |||
| pub fn to_der(&self) -> Result<Vec<u8>, Error> { | |||
| Ok(self.0.to_der()) | |||
| } | |||
|
|
|||
| pub fn to_pem(&self) -> Result<Vec<u8>, Error> { | |||
| panic!("Not implemented on macOS/iOS"); | |||
There was a problem hiding this comment.
Seems that there's currently no implementation in the underlying rust-security-framework crate. I'll see if I can do anything there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing fancy. Add support to generate PEM formatted certificate from
Certificate, in addition to the already-supported DER format.