Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/high priority label centering #216

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Fix/high priority label centering #216

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0596226
fix high priority label w/out transition
nickvisut Aug 30, 2024
e6cdc19
attempt to use transition-behavior instead to show/hide
nickvisut Aug 31, 2024
83bdf02
tweak list's card expand/collapse transition
nickvisut Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/components/MapListCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@ const MapListCard: React.FC<MapListCardProps> = ({
}
return (
<div
className={`grid cursor-pointer grid-cols-10 rounded-lg border-2 bg-white max-md:overflow-hidden ${isExpanded ? "max-h-[300px]" : "max-h-[104px]"} transition-max-height relative duration-[700ms]`}
className={`relative grid cursor-pointer grid-cols-10 rounded-lg border-2 bg-white max-md:overflow-hidden`}
onClick={onClick}
id={name}
>
<div className="col-span-6 justify-center overflow-hidden px-4 pb-4 transition-all ease-in-out md:col-span-7">
<div className="flex h-[104px] flex-col justify-center">
<div className="col-span-6 justify-center overflow-hidden px-4 py-4 transition-all ease-in-out md:col-span-7">
<div className="flex flex-col">
{school.priority && (
<button
onClick={(e) => {
Expand All @@ -81,7 +81,9 @@ const MapListCard: React.FC<MapListCardProps> = ({
</div>
</div>

<div className="flex flex-col gap-2 max-md:text-sm">
<div
className={`flex flex-col gap-2 transition-all duration-[700ms] [transition-behavior:allow-discrete] max-md:text-sm ${isExpanded ? "visible mt-4 max-h-48 opacity-100" : "invisible mt-0 max-h-0 opacity-0"}`}
>
<div>
<b>{students ? students.value : "N/A"}</b> Students
</div>
Expand All @@ -100,7 +102,7 @@ const MapListCard: React.FC<MapListCardProps> = ({
</div>
</div>
<div
className={`transition-max-height relative col-span-4 rounded-r-lg duration-[700ms] md:col-span-3 ${isExpanded ? "max-h-[300px]" : "max-h-[104px]"}`}
className={`transition-max-height relative col-span-4 max-h-none rounded-r-lg duration-[700ms] md:col-span-3`}
>
<Image
src={`/school_img/${school.img}`}
Expand Down