Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WSL2 support for hyperlinks #1608

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TiltedToast
Copy link

I noticed that the hyperlinks generated by fd don't quite work inside wsl2 as you have to use a very specific hostname in this case.

Thankfully as far as I'm aware every officially supported wsl2 distro comes with the wslpath utility that can quickly convert between windows and wsl paths so getting the hostname is as easy as calling that with the root of the file system as an argument.

Performance wise this shouldn't cause any issues, since it only runs once regardless of how many files are being printed. Other unix environments should be unaffected by this, since it'll just silently fail and use gethostname as usual.

@tavianator
Copy link
Collaborator

@TiltedToast
Copy link
Author

TiltedToast commented Aug 23, 2024

Yeah you're right, that is definitely a better way of doing it. It also seems that ripgrep automatically detects common terminals and uses their specific schemes, seems like something that might be worth looking into hmm

EDIT:

Seems like I was mistaken, looks like they don't do any checks like that and just let the user choose a format if they want to have one. VS Code's integrated terminal in my case just does this on its own I guess, they do bundle it for their own search iirc so makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants