Fix disabling of GOG DB and Official site links when disabled in exte… (

#80) * Fix disabling of GOG DB and Official site links when disabled in extension options * Fix disabling of GOG DB and Official site links when disabled in extension options
sharkusmanch · Mar 5, 2024 · 60442d3 · 60442d3
1 parent fe45e46
commit 60442d3
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 4 deletions.
diff --git a/extension.yaml b/extension.yaml
@@ -1,7 +1,7 @@
 Id: PCGamingWikiMetadata_c038558e-427b-4551-be4c-be7009ce5a8d
 Name: PCGamingWiki Metadata Provider
 Author: sharkusmanch
-Version: 1.2.4
+Version: 1.2.5
 Module: PCGamingWikiMetadata.dll
 Type: MetadataProvider
 Icon: icon.png
diff --git a/manifest.yaml b/manifest.yaml
@@ -1,5 +1,11 @@
 AddonId: PCGamingWikiMetadata_c038558e-427b-4551-be4c-be7009ce5a8d
 Packages:
+- Version: 1.2.5
+  RequiredApiVersion: 6.11.0
+  ReleaseDate: 2024-03-04
+  PackageUrl: https://github.com/sharkusmanch/playnite-pcgamingwiki-metadata-provider/releases/download/v1.2.5/PCGamingWiki_Metadata_Provider_v1.2.5.pext
+  Changelog:
+    - Fix disabling of GOG DB and Official site links via extension settings
 - Version: 1.2.4
   RequiredApiVersion: 6.11.0
   ReleaseDate: 2024-02-16

diff --git a/src/PCGamingWikiHTMLParser.cs b/src/PCGamingWikiHTMLParser.cs
@@ -392,10 +392,10 @@ private void AddLinks(HtmlNode icons)
                 switch (c.Attributes["Title"].Value)
                 {
                     case var title when new Regex(@"^Official site$").IsMatch(title):
-                        this.gameController.Game.Links.Add(new Playnite.SDK.Models.Link("Official site", url));
+                        this.gameController.AddLink(new Playnite.SDK.Models.Link("Official site", url));
                         break;
                     case var title when new Regex(@"GOG Database$").IsMatch(title):
-                        this.gameController.Game.Links.Add(new Playnite.SDK.Models.Link("GOG Database", url));
+                        this.gameController.AddLink(new Playnite.SDK.Models.Link("GOG Database", url));
                         break;
                     default:
                         string[] linkTitle = c.Attributes["Title"].Value.Split(' ');

diff --git a/tests/PCGWGame_Test_BAT.cs b/tests/PCGWGame_Test_BAT.cs
@@ -23,6 +23,7 @@ public PCGWGame_Test_BAT()
         this.client.GetSettings().ImportFeatureVR = true;
         this.client.GetSettings().ImportTagMonetization = true;
         this.client.GetSettings().ImportTagMicrotransactions = true;
+        this.client.GetSettings().ImportLinkGOGDatabase = false;
         this.client.FetchGamePageContent(this.testGame);
     }
 
@@ -180,6 +181,7 @@ public void TestLinks()
     {
         var links = this.testGame.Links.Select(i => i.Name).ToArray();
         links.Should().NotContain("WineHQ");
+        links.Should().NotContain("GOG Database");
         links.Should().Contain("IGDB");
     }
 

diff --git a/tests/PCGWGame_Test_CITIES.cs b/tests/PCGWGame_Test_CITIES.cs
@@ -7,7 +7,7 @@
 public class PCGWGame_Test_CITIES : IDisposable
 {
     private PCGWGame testGame;
-    private PCGWClient client;
+    private LocalPCGWClient client;
     private TestMetadataRequestOptions options;
 
     public PCGWGame_Test_CITIES()
@@ -16,6 +16,7 @@ public PCGWGame_Test_CITIES()
         this.options = new TestMetadataRequestOptions();
         this.options.SetGameSourceSteam();
         this.client = new LocalPCGWClient(this.options);
+        this.client.GetSettings().ImportLinkOfficialSite = false;
         this.client.FetchGamePageContent(this.testGame);
     }
 
@@ -119,6 +120,13 @@ public void TestControllerSupport()
         features.Should().NotContain("Full Controller Support");
     }
 
+    [Fact]
+    public void TestLinks()
+    {
+        var features = this.testGame.Links.Select(i => i.Name).ToArray();
+        features.Should().NotContain("Official site");
+    }
+
     [Fact]
     public void TestVR()
     {