Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ar] cs-229-supervised-learning, cs-229-machine-learning-tips-and-tricks #87

Merged
merged 14 commits into from
Nov 5, 2019

Conversation

qunaieer
Copy link
Contributor

[ar] Supervised Learning

@shervinea shervinea added the in progress Work in progress label Oct 20, 2018
@qunaieer
Copy link
Contributor Author

I am planning to finish this file by the end of this week. I will merge it after I complete the file.

First draft is finished, I need to go back and heaveliy revise it. It is still not finished.
@qunaieer
Copy link
Contributor Author

First draft is finished, I need to go back and heavily revise it. It is still not finished.

The translation of this file is complete. I have finished from it according to the agreed terminologies on this webpage: https://www.nmthgiat.com/terminology/
@qunaieer
Copy link
Contributor Author

qunaieer commented Sep 2, 2019

The translation of this file is complete, according to the terminologies on: https://www.nmthgiat.com/terminology/

@shervinea shervinea added reviewer wanted Looking for a reviewer and removed in progress Work in progress labels Sep 2, 2019
@shervinea
Copy link
Owner

Thank you @qunaieer for all your work! Now, let's start the review process.

@zaidalyafeai
Copy link
Contributor

Will work on the review. Thanks @qunaieer .

ar/cheatsheet-supervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-supervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-supervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-supervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-supervised-learning.md Outdated Show resolved Hide resolved
@zaidalyafeai
Copy link
Contributor

Finished half of the review @qunaieer .

@qunaieer
Copy link
Contributor Author

Thank you @zaidalyafeai
Please let me know if you finish, and I will go through the comments.

ar/cheatsheet-supervised-learning.md Outdated Show resolved Hide resolved
ar/cheatsheet-supervised-learning.md Outdated Show resolved Hide resolved
@zaidalyafeai
Copy link
Contributor

@qunaieer, I am done with the review.

@qunaieer
Copy link
Contributor Author

Thank you @zaidalyafeai for the reivew.
How can I make changes? should I make them on the file in my machine, then do pull request? or is there a way to edit them directly here? @shervinea

@zaidalyafeai
Copy link
Contributor

@qunaieer you are welcome. I think it is more convenient to make them offline then make a PR. You should use the same fork that you used initially in order to append the changes to the current PR.

Finished translation of the file: cheatsheet-machine-learning-tips-and-tricks.md
modifications of cheatsheet-supervised-learning.md file after @zaidalyafeai comments.
@qunaieer
Copy link
Contributor Author

I have updated the file cheatsheet-supervised-learning.md according to @zaidalyafeai comments.

@shervinea
Copy link
Owner

Thank you very much @qunaieer and @zaidalyafeai for your hard work!

I see that the machine-learning-tips-and-tricks translation has also been added to this PR. @zaidalyafeai: could you please also review it? That way, we will be able to merge these two files at once.

@zaidalyafeai
Copy link
Contributor

@shervinea sure, will take a stab at it asap.

@zaidalyafeai
Copy link
Contributor

@qunaieer finished the review, excellent translation with minimal changes.

Modification on cheatsheet-machine-learning-tips-and-tricks.md file after @zaidalyafeai review.
@qunaieer
Copy link
Contributor Author

Thank you @zaidalyafeai for the review. I have changed the file accordingly and made a pull request.
I am not sure how to just select the changed file when doing pull request! It sends all the files I worked on previously.

@zaidalyafeai
Copy link
Contributor

@qunaieer you can commit a certain file by git commit -m "my message" path/to/my/file

@shervinea shervinea changed the title [ar] Supervised Learning [ar] Supervised Learning, ML tips and tricks Oct 21, 2019
@shervinea
Copy link
Owner

Thank you both @qunaieer and @zaidalyafeai for all your work. On my side, I added a few commits to:

  • synchronize @qunaieer's fork to the repository's latest state
  • restore a template that had been overwritten by the proposed merge and move the associated translation to the [ar] directory
  • add your names in the contributors file

@zaidalyafeai: would you have any more comments or would you say that this PR is now ready for merge?

@qunaieer
Copy link
Contributor Author

Thank you @shervinea
As we discussed here #84 (comment)
It seems I need to add some tags to enable rtl. I will do this to the files and let you know.
Is this the method used for the other rtl languages (e.g., Persian)?

@shervinea
Copy link
Owner

@qunaieer Yes exactly, wrapping translations within rtl tags would be awesome (e.g. as in #129). Thank you for being so meticulous and for thinking of it!

@qunaieer
Copy link
Contributor Author

qunaieer commented Nov 3, 2019

Hello @shervinea I have updated the two files with RTL tags.

@shervinea
Copy link
Owner

Thank you very much @qunaieer, it looks great! Moving forward with the merge.

@shervinea shervinea merged commit 9f16d19 into shervinea:master Nov 5, 2019
@shervinea shervinea changed the title [ar] Supervised Learning, ML tips and tricks [ar] Supervised Learning, cs-229-machine-learning-tips-and-tricks Oct 6, 2020
@shervinea shervinea changed the title [ar] Supervised Learning, cs-229-machine-learning-tips-and-tricks [ar] cs-229-supervised-learning, cs-229-machine-learning-tips-and-tricks Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewer wanted Looking for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants