option to use unbound to configure timeouts #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… box Also add unbound in configure.ac so that configure can detect the presence of unbound library. You will have to run bootstrap to recompile with unbound.
This doesn't use the unbound parsing since unbound_result doesn't have the ttl field which is used by the libspf2 caching code. Use the raw answer packet and parse the fields the old way. (We could use ldns if we want to, but I just used the same code that does the parsing). The ultimate goal is to use the unbound async call to configure a timeout for the dns lookups.
Timeouts can be configured by using a call to SPF_server_set_dns_timeout. Use select and unbound async calls to achieve timeout. In case we timeout, cancel the unbound query. The default timeout is set to be 5.0 seconds.
|
Currently squashed into a branch, managed to keep the author attribution. Will reformat and merge. |
|
@shevek Would you still accept this PR were the conflicts to be resolved? Of note, from one of the commits:
This is no longer true; unbound_result has included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unbound is an async dns library and provides features like DNSSEC, caching, etc.